OS X fixes #902
Merged
OS X fixes #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that Doxygen defines LIBICONV_PLUG on OS X, which causes the `iconv.h` header file to not prefix the functions with `lib` and then linker cannot find it.
Member
Author
|
@ahmadia, @johannesring would you mind reviewing this? |
Contributor
|
I have used a similar approach for the FEniCS installation script. That is, leaving |
Contributor
|
... because the latest Xcode only comes with 10.11 SDK. I don't remember exactly now unfortunately. |
Member
Author
|
Thanks. It works for me, so I am going to merge this. |
Contributor
There was a problem hiding this comment.
@certik - I think this change also requires a change in cmake_package.yaml because setting empty_osx_deployment_target: true has currently no effect. I think what is missing is this:
diff --git a/base/cmake_package.yaml b/base/cmake_package.yaml
index 3cd08de..7464694 100644
--- a/base/cmake_package.yaml
+++ b/base/cmake_package.yaml
@@ -15,6 +15,7 @@ build_stages:
- name: configure
after: setup_builddir
debug: {{debug}}
+ empty_osx_deployment_target: {{empty_osx_deployment_target}}
- name: make
after: configure
Contributor
|
Sorry I missed this. It looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few fixes to get things working for El Capitan.