Sync bootstrap config from consul/main#101
Merged
Merged
Conversation
freddygv
added
the
pr/no-changelog
ndhanushkodi
approved these changes
May 9, 2023
| @@ -91,19 +94,6 @@ const ( | |||
| ] | |||
| } | |||
There was a problem hiding this comment.
just checking, is this file diff bigger because the changes weren't synced recently?
Contributor
Author
There was a problem hiding this comment.
It's because the original changes from #90 weren't synced via the Makefile target, and were a bit different from the Consul changes
Now things are the same on both sides
This was referenced May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated with
make copy-bootstrap-configto sync changes from hashicorp/consul#17204UNIX domain socket paths are limited to 104-108 characters depending on the OS. This limit was quite easy to exceed when testing the feature on Kubernetes, due to how proxy IDs encode the Pod ID eg:
metrics-collector-59467bcb9b-fkkzl-hcp-metrics-collector-sidecar-proxyTo ensure we stay under the lower 104 character limit this commit makes a couple changes: