Backport of Sync bootstrap config from consul/main into release/1.0.x#102
Merged
hc-github-team-consul-core merged 2 commits intoMay 9, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/cc-4929-copy-bootstrap-config/deeply-optimal-sculpin
branch
from
29d77c9 to
01b1a3e
Compare
malizz
approved these changes
May 9, 2023
hc-github-team-consul-core
deleted the
backport/cc-4929-copy-bootstrap-config/deeply-optimal-sculpin
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #101 to be assessed for backporting due to the inclusion of the label backport/1.0.
The below text is copied from the body of the original PR.
Updated with
make copy-bootstrap-configto sync changes from hashicorp/consul#17204UNIX domain socket paths are limited to 104-108 characters depending on the OS. This limit was quite easy to exceed when testing the feature on Kubernetes, due to how proxy IDs encode the Pod ID eg:
metrics-collector-59467bcb9b-fkkzl-hcp-metrics-collector-sidecar-proxyTo ensure we stay under the lower 104 character limit this commit makes a couple changes:
Overview of commits