Crt migration 1.11.0 betax#11417
Merged
Merged
Conversation
Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
github-actions
Bot
added
the
theme/contributing
Copied from hashicorp/linux-packaging https://github.com/hashicorp/linux-packaging/tree/24e7e2675b2795b02147313e18848233d6a3975c Signed-off-by: Scott Macfarlane <smacfarlane@hashicorp.com>
99
force-pushed
the
crt-migration-1.11.0-betax
branch
from
0250997 to
34d62a9
Compare
dnephin
added
the
pr/no-changelog
mdeggies
reviewed
Oct 27, 2021
dnephin
reviewed
Oct 28, 2021
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Thanks! I think this looks great. Just a few questions/suggestions
dnephin
reviewed
Oct 28, 2021
Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>
99
force-pushed
the
crt-migration-1.11.0-betax
branch
from
4b5bb36 to
77ed84a
Compare
99
force-pushed
the
crt-migration-1.11.0-betax
branch
from
bb7b56d to
73e6f5d
Compare
99
force-pushed
the
crt-migration-1.11.0-betax
branch
from
73e6f5d to
0402cc1
Compare
Contributor
Author
|
Hi, @dnephin I hope I've addressed all the comments/requests please let me know if anything I've missed. Thank you. |
dnephin
approved these changes
Nov 1, 2021
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
LGTM, thanks for all your work on this!
I think leaving the go version cleanup and dockerfile/entrypoint de-duplication for a follow is a good plan.
Collaborator
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/490325. |
This was referenced Nov 3, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will update consul workflow with new release flow