ci: set CGO_ENABLED: 0 for arm/arm64 builds#10610
Closed
mikemorris wants to merge 1 commit into
Closed
Conversation
Contributor
|
With golang/go#34030 in Go 1.14, we should be able to compile arm/arm64 normally without having to download the gcc libraries IIRC. We just never switched it. I don't know if we just need a |
Contributor
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7970 for context on the ARM crash in versions of Go prior to 1.14 that required enabling CGO.
As an open question, is the suggested approach in #6519 (comment) sufficient for running on ARMv7 hardware @jwalzer @mrmstn? It seems that approach (aside from the reported bug) has been working for some users according to #10545.
TODO: This change only affects our test suite, and will require a followup to our build pipelines if it looks good to merge.a