Backport of Fix Backport Assistant PR commenting into release/1.15.x#18202
Merged
zalimeni merged 1 commit intoJul 20, 2023
Conversation
c98767a to
1f00ccd
Compare
88e702e to
1f00ccd
Compare
github-team-consul-core-pr-approver
approved these changes
Jul 20, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
* Fix Backport Assistant failure PR commenting For general comments on a PR, it looks like you have to use the `/issue` endpoint rather than `/pulls`, which requires commit/other review-specific target details. This matches the endpoint used in `backport-reminder.yml`. * Remove Backport Reminder workflow This is noisy (even when adding multiple labels, individual comments per label are generated), and likely no longer needed: we haven't had this work in a long time due to an expired GH token, and we now have better automation for backport PR assignment. Manual backport of 1c7fcdf.
1f00ccd to
a8ca204
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18200 to be assessed for backporting due to the inclusion of the label backport/1.15.
🚨
The person who merged in the original PR is:
@zalimeni
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
For general comments on a PR, it looks like you have to use the
/issueendpoint rather than/pulls, which requires commit/other review-specific target details.This matches the endpoint used in
backport-reminder.yml.Also remove the noisier Backport Reminder workflow in favor of recent automation to assign backport PRs to authors.
Description
Follow-up to #17197, plus a noise-reduction fix.
Testing & Reproduction steps
Ran:
and it worked. (I also fat-fingered the PR I meant to target the first time 😛)
PR Checklist
Overview of commits