Post a PR comment if the backport runner fails#17197
Merged
Merged
Conversation
freddygv
requested review from
a team and
xwa153
and removed request for
a team
github-actions
Bot
added
theme/contributing
freddygv
added
pr/no-backport
pr/no-changelog
DanStough
approved these changes
May 9, 2023
Contributor
DanStough
left a comment
DanStough
left a comment
There was a problem hiding this comment.
Nice! I wouldn't be opposed to backporting this to the release branches.
This was referenced May 9, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on:
Currently when the backport runner fails it fails silently. This commit adds a step to comment on the PR so that the author can know it failed.
Opted not to post to a Slack channel because not everyone is in the GH/CI feed channels, and it could be too noisy for #team-consul.
I'm not sure about how to test that this works, open to suggestions!