Skip to content

Backport of Fix Backport Assistant PR commenting into release/1.16.x#18203

Merged
hc-github-team-consul-core merged 2 commits into
release/1.16.xfrom
backport/zalimeni/fix-backport-failure-pr-comments/constantly-striking-swine
Jul 20, 2023
Merged

Backport of Fix Backport Assistant PR commenting into release/1.16.x#18203
hc-github-team-consul-core merged 2 commits into
release/1.16.xfrom
backport/zalimeni/fix-backport-failure-pr-comments/constantly-striking-swine

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #18200 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


For general comments on a PR, it looks like you have to use the /issue endpoint rather than /pulls, which requires commit/other review-specific target details.

This matches the endpoint used in backport-reminder.yml.

Also remove the noisier Backport Reminder workflow in favor of recent automation to assign backport PRs to authors.

Description

Follow-up to #17197, plus a noise-reduction fix.

Testing & Reproduction steps

Ran:

github_message="Backport failed @zalimeni. Run: [this is a test to fix broken commenting, no link included]"
          curl -s -H "Authorization: token ${PR_COMMENT_TOKEN}" \
            -X POST \
            -d "{ \"body\": \"${github_message}\"}" \
            "https://api.github.com/repos/hashicorp/consul/issues//comments"

and it worked. (I also fat-fingered the PR I meant to target the first time 😛)

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/fix-backport-failure-pr-comments/constantly-striking-swine branch from 2b58963 to e6eedf7 Compare July 20, 2023 15:39
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/zalimeni/fix-backport-failure-pr-comments/constantly-striking-swine branch 2 times, most recently from 0c57c5c to 0030d56 Compare July 20, 2023 15:39
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) July 20, 2023 15:39
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@github-actions github-actions Bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jul 20, 2023
@vercel vercel Bot temporarily deployed to Preview – consul-ui-staging July 20, 2023 15:42 Inactive
@vercel vercel Bot temporarily deployed to Preview – consul July 20, 2023 15:45 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 4c637e4 into release/1.16.x Jul 20, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/zalimeni/fix-backport-failure-pr-comments/constantly-striking-swine branch July 20, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants