Add validation for apigw creation with no routes#16649
Conversation
| } | ||
|
|
||
| if len(e.Listeners) == 0 { | ||
| return errors.New("api gateway must have at least one listener") |
There was a problem hiding this comment.
minor (and more stylistic than anything and not blocking), would we want to use a sentinel error here so callers could act on the error type in the future?
There was a problem hiding this comment.
So I don't feel like that matches the way the other validations are handled, but I'm also realizing I didn't follow that way either. Ex: https://github.com/hashicorp/consul/blob/main/agent/structs/config_entry_gateways.go#L803
I do think that is probably a good idea for the future though
There was a problem hiding this comment.
Especially because I think it sends a 500 error back right now
t-eckert
left a comment
t-eckert
left a comment
There was a problem hiding this comment.
This is great! Would you mind just formatting the .mdx tables you added so the vertical bars align?
4 participants
Description
To meet the standard (Gateways require at least one listener defined) we need to add checks in to verify that at least one listener is defined.
Testing & Reproduction steps
Open another terminal, create a file called gateway.hcl with the following content:
After creating the file, run the following command in the same terminal:
This should error out, saying "api gateway must have at least one listener"
PR Checklist