Backport of Add validation for apigw creation with no routes into release/1.15.x#16679
Merged
missylbytes merged 8 commits intoMar 20, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/add-checks-apigw-creation-no-routes/personally-winning-foxhound
branch
from
470712c to
fb50745
Compare
hc-github-team-consul-core
force-pushed
the
backport/add-checks-apigw-creation-no-routes/personally-winning-foxhound
branch
2 times, most recently
from
ceeddce to
87b968b
Compare
github-team-consul-core-pr-approver
approved these changes
Mar 20, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
Bot
added
the
type/docs
…-no-routes/personally-winning-foxhound
missylbytes
deleted the
backport/add-checks-apigw-creation-no-routes/personally-winning-foxhound
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16649 to be assessed for backporting due to the inclusion of the label backport/1.15.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
To meet the standard (Gateways require at least one listener defined) we need to add checks in to verify that at least one listener is defined.
Testing & Reproduction steps
Open another terminal, create a file called gateway.hcl with the following content:
After creating the file, run the following command in the same terminal:
This should error out, saying "api gateway must have at least one listener"
PR Checklist
Overview of commits