Skip to content

Fix BUSL license checker to skip >= 1.17.x target branches#19152

Merged
analogue merged 2 commits into
release/1.17.xfrom
spatel/fix-busl-checker
Oct 11, 2023
Merged

Fix BUSL license checker to skip >= 1.17.x target branches#19152
analogue merged 2 commits into
release/1.17.xfrom
spatel/fix-busl-checker

Conversation

@analogue
Copy link
Copy Markdown
Contributor

@analogue analogue commented Oct 11, 2023

Description

Just testing this out on the release branch and then will rubberstamp in all the places.

Testing & Reproduction steps

$ cat crap.sh                                                                                                                                                                                                                                     
#!/bin/bash
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: BUSL-1.1

if [[ ${GITHUB_BASE_REF} == release/1.14.* ]] || [[ ${GITHUB_BASE_REF} == release/1.15.* ]] || [[ ${GITHUB_BASE_REF} == release/1.16.* ]]; then
    echo "Matched!"
else
    echo "skipped"
fi%                                                                                                                                                                                                                                                                                                                         

$ GITHUB_BASE_REF="release/1.14.x" ./crap.sh
Matched!

$ GITHUB_BASE_REF="release/1.14.2" ./crap.sh
Matched!

$ GITHUB_BASE_REF="release/1.15.x" ./crap.sh
Matched!

$ GITHUB_BASE_REF="release/1.15.4" ./crap.sh
Matched!

$ GITHUB_BASE_REF="release/1.16.x" ./crap.sh
Matched!

$ GITHUB_BASE_REF="release/1.16.4" ./crap.sh
Matched!

$ GITHUB_BASE_REF="release/1.17.x" ./crap.sh
skipped

$ GITHUB_BASE_REF="release/1.17.0" ./crap.sh
skipped

@analogue analogue added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 11, 2023
@github-actions github-actions Bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Oct 11, 2023
@analogue
Copy link
Copy Markdown
Contributor Author

Results:

https://github.com/hashicorp/consul/actions/runs/6488227092/job/17620216610?pr=19152

Run ./.github/scripts/license_checker.sh
./.github/scripts/license_checker.sh
shell: /usr/bin/bash -e {0}
Skipping BUSL check since release/1.17.x not one of release/1.14.*, release/1.15.*, or release/1.16.*.

Comment thread .github/scripts/license_checker.sh Outdated
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
@analogue analogue merged commit 76f5b71 into release/1.17.x Oct 11, 2023
@analogue analogue deleted the spatel/fix-busl-checker branch October 11, 2023 21:52
analogue added a commit that referenced this pull request Oct 11, 2023
* Fix BUSL license checker to skip >= 1.17.x target branches

* Update .github/scripts/license_checker.sh

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>

---------

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
analogue added a commit that referenced this pull request Oct 11, 2023
…19154)

* Fix BUSL license checker to skip >= 1.17.x target branches

* Update .github/scripts/license_checker.sh



---------

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
hc-github-team-consul-core added a commit that referenced this pull request Oct 11, 2023
#19152) into release/1.14.x (#19155)

backport of commit 02bfe1d

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
hc-github-team-consul-core added a commit that referenced this pull request Oct 11, 2023
#19152) into release/1.15.x (#19156)

backport of commit 02bfe1d

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
hc-github-team-consul-core added a commit that referenced this pull request Oct 11, 2023
#19152) into release/1.16.x (#19157)

backport of commit 02bfe1d

Co-authored-by: Semir Patel <semir.patel@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants