Skip to content

Run license-check for all release branches so required CI rules are met#19153

Closed
nathancoleman wants to merge 2 commits into
mainfrom
license-check-all-release-branches
Closed

Run license-check for all release branches so required CI rules are met#19153
nathancoleman wants to merge 2 commits into
mainfrom
license-check-all-release-branches

Conversation

@nathancoleman
Copy link
Copy Markdown
Member

@nathancoleman nathancoleman commented Oct 11, 2023

Description

All release branches have a protection rule that requires the license-check job to run; however, this currently only runs for Consul 1.14-1.16 release branches.

This changes the job to run for all release branches but skip the actual check for anything that isn't Consul 1.14-1.16 release branches. This will allow the CI requirement to be met even for PRs targeting release/1.17.x.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 11, 2023
@github-actions github-actions Bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Oct 11, 2023
@nathancoleman nathancoleman added backport/1.17 and removed type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials pr/no-backport labels Oct 11, 2023
@nathancoleman
Copy link
Copy Markdown
Member Author

Closing in favor of #19152

@nathancoleman nathancoleman deleted the license-check-all-release-branches branch October 11, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant