Upgrade Consul UI to Node 18 (#19252)#19362
Merged
Merged
Conversation
* Upgrading node to node 18 * Ensure we're on latest version of yarn as well * add comma to make frontend tests run * Use Node 18 Alpine image in UI build dockerfile * delete package-lock.json --------- Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com> Co-authored-by: Ella Cai <ella.y.cai@gmail.com> Co-authored-by: Ella Cai <ella@hashicorp.com>
WenInCode
requested review from
emilymianeil and
modrake
and removed request for
a team
github-actions
Bot
added
type/ci
Contributor
Author
|
There is no nightly test 1.17 on the release/1.17 branch, I'm assuming the 1.13 branch got renamed to it so I removed those changes here. |
chris-hut
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of changes made in #19252 to
release/1.17.xThe original backport looks to have gotten caught up in the backport backlog when they were disabled during the cutting of the ga branch and subsequently removed from the merged code in this PR: #19350
Manually backporting it into the
release/1.17.xbranchTesting & Reproduction steps
Links
Original PR
Failed backport
PR Checklist