[ui] Namespaced and file-specified deps for consul-ui#21378
Merged
Conversation
Contributor
|
Awesome work @philrenaud, thanks a lot for doing that this quickly 🙌 |
4007e05 to
e18b631
Compare
Collaborator
Author
|
Note: in order to resolve a non-standard license in a dependency-of-dependency-of-dependency, in 36fef17e6cdc9dbb088de1bbad9bc4ed44eee6ee I've done two things:
|
ee4cc11 to
7277670
Compare
a2e4715 to
79d8b85
Compare
…ackages to come from npmjs
79d8b85 to
8d13103
Compare
dduzgun-security
approved these changes
Jul 8, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This resolves an ambiguous dependency resolution in consul-ui in the event that a developer attempted to
yarn installornpm installfrom a non-workspace-root directory. This handles it in two ways:@hashicorp/prefix, reducing the risk of a hypothetical public registry squat situation should local packages ever stop being relativeSomething to note with this is that the packages become a little more bound together than before; for example, it would be more difficult to maintain multiple valid versions of a sub-package here and let
consul-uidifferentiate between them. We could expand this into submodules some day, but not today.