Backport of [ui] Namespaced and file-specified deps for consul-ui into release/1.19.x#21523
Merged
philrenaud merged 5 commits intoJul 8, 2024
Conversation
github-team-consul-core-pr-approver
approved these changes
Jul 8, 2024
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
philrenaud
deleted the
backport/NET-10157-consul-ui-devdep-specificity/badly-big-slug
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21378 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
Description
This resolves an ambiguous dependency resolution in consul-ui in the event that a developer attempted to
yarn installornpm installfrom a non-workspace-root directory. This handles it in two ways:@hashicorp/prefix, reducing the risk of a hypothetical public registry squat situation should local packages ever stop being relativeSomething to note with this is that the packages become a little more bound together than before; for example, it would be more difficult to maintain multiple valid versions of a sub-package here and let
consul-uidifferentiate between them. We could expand this into submodules some day, but not today.Overview of commits