fix: bump subnav to fix dot-io layout shift#413
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ "Ready for Review" checklist
🔗 Relevant links
🗒️ What
Bumps
@hashicorp/react-subnavto pull in a fix for a layout shift issue related tosubnav.🤷 Why
Existing behaviour
iswas causing significant layout shift on mobile, and all dot-io pages. Issue has since been addressed through a different mechanism, but felt safe to implement this fix as well.🛠️ How
Underlying fix:
Sets
overflow: hiddenon subnav, so that initial state is better guaranteed to not exceed the viewport width.🧪 Testing
💭 Anything else?