Skip to content

fix: bump subnav to fix dot-io layout shift#413

Merged
zchsh merged 10 commits into
mainfrom
zs.fix-dot-io-layout-shift-subnav-attempt
May 13, 2022
Merged

fix: bump subnav to fix dot-io layout shift#413
zchsh merged 10 commits into
mainfrom
zs.fix-dot-io-layout-shift-subnav-attempt

Conversation

@zchsh
Copy link
Copy Markdown
Contributor

@zchsh zchsh commented May 10, 2022

✅ "Ready for Review" checklist

  • The Vercel preview link has been added to this PR's description
  • The Asana task has been added to this PR's description
  • This PR's link has been added to the "📐 Pull Request" field on the Asana task
  • This Vercel preview link has been added to the "🔍 Preview" field on the Asana task
  • The description template has been filled in below

🔗 Relevant links

🗒️ What

Bumps @hashicorp/react-subnav to pull in a fix for a layout shift issue related to subnav.

🤷 Why

Existing behaviour is was causing significant layout shift on mobile, and all dot-io pages. Issue has since been addressed through a different mechanism, but felt safe to implement this fix as well.

🛠️ How

Underlying fix:

🧪 Testing

  • Visit the preview homepage, switch to a dot-io site using the product switcher in the lower left, and confirm that layout shift due to initial sidenav overflow is no longer happening.

💭 Anything else?

@vercel
Copy link
Copy Markdown

vercel Bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dev-portal ✅ Ready (Inspect) Visit Preview May 13, 2022 at 5:53PM (UTC)

@zchsh zchsh changed the title chore: bump to test pre-release fix: bump subnav to fix dot-io layout shift May 10, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2022

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@zchsh zchsh requested a review from brkalow May 11, 2022 15:12
@zchsh zchsh marked this pull request as ready for review May 11, 2022 15:12
Copy link
Copy Markdown
Contributor

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@zchsh zchsh merged commit 7d7e82a into main May 13, 2022
@zchsh zchsh deleted the zs.fix-dot-io-layout-shift-subnav-attempt branch May 13, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants