This repository was archived by the owner on Dec 17, 2025. It is now read-only.
fix(subnav): dot-io layout shift issue#586
Merged
Merged
Conversation
zchsh
added
the
release:canary
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 49b7adc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Canary Packages PublishedLatest commit: 49b7adc Published 1 packages@hashicorp/react-subnav@9.3.5-canary-20220510154113 |
5 tasks
Contributor
Author
|
@brkalow I think this fix might not be necessary anymore, but also figure it doesn't hurt and may catch future edge cases, so figure worth merging regardless. Let me know what you think 🙇♂️ |
dstaley
approved these changes
May 11, 2022
Merged
This was referenced Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Asana Task
🔍 Preview Link
Description
This PR fixes an issue in
@hashicorp/react-subnavwhere, before overflow detection, subnav might cause horizontal overflow in some situations.Note: this fix was initially made to address an issue with layout shift on mobile. The specific issue has since been resolved in another way, but this fix still felt worth merging.
PR Checklist 🚀
Items in this checklist may not may not apply to your PR, but please consider each item carefully.