Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

fix(subnav): revert flawed fix for overflow issue#702

Merged
zchsh merged 1 commit into
mainfrom
zs.revert-bad-overflow-change
Aug 18, 2022
Merged

fix(subnav): revert flawed fix for overflow issue#702
zchsh merged 1 commit into
mainfrom
zs.revert-bad-overflow-change

Conversation

@zchsh
Copy link
Copy Markdown
Contributor

@zchsh zchsh commented Aug 18, 2022

Reverts flawed fix from #586 .

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Aug 18, 2022

🦋 Changeset detected

Latest commit: 92bbef8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-subnav Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-components ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 3:47PM (UTC)

@zchsh
Copy link
Copy Markdown
Contributor Author

zchsh commented Aug 18, 2022

@alexcarpenter This PR reverts the flawed fix that was causing issues, as mentioned in hashicorp/dev-portal#429 (comment).

Let me know if it looks alright to you 🙇‍♂️

Copy link
Copy Markdown
Contributor

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Definitely works for me! Thank you.

@zchsh zchsh merged commit bda1c7f into main Aug 18, 2022
@zchsh zchsh deleted the zs.revert-bad-overflow-change branch August 18, 2022 17:12
@hashibot-web hashibot-web mentioned this pull request Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants