Skip to content

handle case when remote ssh server disconnects#4034

Merged
mwhooker merged 1 commit into
masterfrom
sshdisconnect
Oct 21, 2016
Merged

handle case when remote ssh server disconnects#4034
mwhooker merged 1 commit into
masterfrom
sshdisconnect

Conversation

@mwhooker
Copy link
Copy Markdown
Contributor

@mwhooker mwhooker commented Oct 20, 2016

needs a little more work but here's something that works in a way I like

Also adds cool new config syntax that lets us default expect_disconnect to true.

Closes #4011
Replaces #4010
Fixes #4006

@mwhooker mwhooker changed the title [WIP] handle case when remote ssh server disconnects handle case when remote ssh server disconnects Oct 20, 2016
cbednarski
cbednarski reviewed Oct 20, 2016
View reviewed changes
Comment thread provisioner/shell/provisioner.go
// Whether to clean scripts up
SkipClean bool `mapstructure:"skip_clean"`

ExpectDisconnect *bool `mapstructure:"expect_disconnect"`
Copy link
Copy Markdown
Contributor

@cbednarski cbednarski Oct 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@mwhooker
expect_disconnect option
892d5e8 
provisioner/shell: Adds option to fail if the remote server disconnects
us.
@mwhooker mwhooker merged commit 1a87d49 into master Oct 21, 2016
@mwhooker mwhooker deleted the sshdisconnect branch October 21, 2016 19:48
@mwhooker mwhooker mentioned this pull request Oct 21, 2016
Closed
@trodemaster
Copy link
Copy Markdown
Contributor

trodemaster commented Oct 21, 2016

Hey Guys, I think this is still breaking builds. My builds that use ssh communicator and shutdown are failing with "Build 'vmware-iso' errored: Shutdown command has non-zero exit status." this is with Packer v0.11.1.dev (da2262a). Seems like shutdown command should not barf on any error code or disconnect.

@mwhooker mwhooker mentioned this pull request Oct 22, 2016
Merged
@mwhooker
Copy link
Copy Markdown
Contributor Author

mwhooker commented Oct 22, 2016

@trodemaster thanks for the report. I threw up a PR (#4041) which I think might fix this. I wasn't able to reproduce this right away. Would you mind testing this?

@rickard-von-essen
Copy link
Copy Markdown
Contributor

rickard-von-essen commented Oct 22, 2016

Great work!

@berney berney mentioned this pull request Oct 25, 2016
Closed
@rickard-von-essen rickard-von-essen mentioned this pull request Oct 25, 2016
Closed
@trodemaster
Copy link
Copy Markdown
Contributor

trodemaster commented Oct 25, 2016

I have confirmed that this fixes the shutdown issue I was seeing. Thanks
for getting it fixed up!!

Cheers,
Blake

On Sat, Oct 22, 2016 at 4:11 AM, Rickard von Essen <notifications@github.com

wrote:

Great work!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4034 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFZ21FvMCKhcIpDIVKuYTAFIVEewoTHzks5q2e93gaJpZM4Kcpa-
.

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbednarski cbednarski cbednarski left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option to fail shell provisioner if remote disconnects Problem executing reboot in shell provisioner

4 participants

@mwhooker @trodemaster @rickard-von-essen @cbednarski