VMware shutdown fails

[mwhooker]

WIP. should resolve issue reported in #4034

I looked at how all the other shutdown steps did this:

• https://github.com/mitchellh/packer/blob/master/builder/digitalocean/step_shutdown.go
• https://github.com/mitchellh/packer/blob/master/builder/parallels/common/step_shutdown.go
• https://github.com/mitchellh/packer/blob/master/builder/qemu/step_shutdown.go
• https://github.com/mitchellh/packer/blob/master/builder/virtualbox/common/step_shutdown.go
• https://github.com/mitchellh/packer/blob/master/builder/vmware/common/step_shutdown.go

and saw none of them actually wait for the remote command to end gracefully.

vmware's step shut down should exit quietly if the vm shut down successfully. If it didn't it'll still timeout.

[mwhooker]

only thing I can think of this breaks is if there's a non-0 exit from command_shutdown and the vm stays up. With this it immediately crashes, but without it times out for p.Timeout.

I think we can get rid of this safely

[rickard-von-essen]

Closes #4054

[geerlingguy]

Confirming this fixes the issue for me on latest Packer build.

[cbreden]

Had the regression and this is working for me now.

[trodemaster]

This fix is good and I have tested it a few times.

[helperton]

I seem to be running into this with packer 1.3.3

PS C:\windows\temp> packer --version
1.3.3

...
...
...
vmware-iso: UltraDefrag 6.1.0, Copyright (c) UltraDefrag Development Team, 2007-2013.
vmware-iso: UltraDefrag comes with ABSOLUTELY NO WARRANTY. This is free software,
vmware-iso: and you are welcome to redistribute it under certain conditions.
vmware-iso:
vmware-iso: C: optimize: 0.02% c
==> vmware-iso: Gracefully halting virtual machine...
==> vmware-iso: Failed to send shutdown command: unknown error Post http://192.168.222.143:5985/wsman: dial tcp 192.168.222.143:5985: connectex: No connection could be made because the target machine actively refused it.
==> vmware-iso: Failed to send shutdown command: unknown error Post http://192.168.222.143:5985/wsman: dial tcp 192.168.222.143:5985: connectex: No connection could be made because the target machine actively refused it.
==> vmware-iso: Step "StepShutdown" failed, aborting...
Build 'vmware-iso' errored: unexpected EOF

[SwampDragons]

@helperton this was merged two years ago, so I suspect that if you're seeing something it's new; can you open a new ticket with steps to reproduce?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.