UI: Fix shape of response anticipated from feature-flags endpoint#10684
Merged
Conversation
Monkeychip
approved these changes
Jan 11, 2021
chelshaw
added a commit
that referenced
this pull request
Jan 11, 2021
…0684) * Fix shape of response anticipated from feature-flags endpoint * Add changelog
pull Bot
pushed a commit
to Zezo-Ai/vault
that referenced
this pull request
Nov 7, 2025
…0684) (hashicorp#10690) Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
JeremiahWork
pushed a commit
to JeremiahWork/vault
that referenced
this pull request
Nov 21, 2025
* VAULT-40037 Updates to PKI observations (hashicorp#10200) * WIP * VAULT-40037 Updates to PKI observations * review feedback * public key size * make fmt * issuerId for sign self issued * remove confusing issuer_name * remove unused var * whoops common name * role -> role_name * role name * VAULT-40618 Update PKI observation timestamps to use RFC-3339 format (hashicorp#10560) * VAULT-40672 public key information for sign intermediate (hashicorp#10684) Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing with the real endpoint, I discovered that the shape of the data does not include a data key as initially thought. This fixes the response parsing and the test so that it works as expected with the live endpoint.