Add documentation about the horizontal cluster scalability of PKI secret engine operations#10745
Merged
Conversation
…ret engine operations
ncabatoff
reviewed
Jan 22, 2021
ncabatoff
reviewed
Jan 22, 2021
|
This pull request is being automatically deployed with Vercel (learn more). vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/rftd0t8p1 [Deployment for 1d2ecca canceled] |
ncabatoff
reviewed
Feb 9, 2021
| | sign-verbatim | Update <sup>*</sup> | | ||
|
|
||
| \* Only if the corresponding role has `no_store` set to true and `generate_lease` | ||
| set to false. If `generate_lease` and `no_store` are true, the lease is forwarded |
Collaborator
There was a problem hiding this comment.
If
generate_leaseandno_storeare true
I don't think that's quite right. How about "If generate_lease is true the lease creation will be forwarded to the active node; if no_store is false the entire request will be forwarded to the active node"?
ncabatoff
approved these changes
Feb 9, 2021
JeremiahWork
pushed a commit
to JeremiahWork/vault
that referenced
this pull request
Nov 21, 2025
* VAULT-40037 Updates to PKI observations (hashicorp#10200) * WIP * VAULT-40037 Updates to PKI observations * review feedback * public key size * make fmt * issuerId for sign self issued * remove confusing issuer_name * remove unused var * whoops common name * role -> role_name * role name * VAULT-40618 Update PKI observation timestamps to use RFC-3339 format (hashicorp#10560) * VAULT-40672 public key information for sign intermediate (hashicorp#10684) Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.