Skip to content

Documentation grammar update for https://www.vaultproject.io/docs/concepts/seal#migration-post-vault-1-5-1#13092

Merged
ncabatoff merged 3 commits into
mainfrom
kwagga-patch-1
Aug 24, 2022
Merged

Documentation grammar update for https://www.vaultproject.io/docs/concepts/seal#migration-post-vault-1-5-1#13092
ncabatoff merged 3 commits into
mainfrom
kwagga-patch-1

Conversation

@kwagga
Copy link
Copy Markdown
Contributor

@kwagga kwagga commented Nov 9, 2021

The following sentence does not read easily:
"Take down the old active node, update its configuration of the old active node to use the new seal blocks (completely unaware of the old seal type) and bring it back up."
I have changed this to the sentence below, which I believe reads better.
"Take down the old active node, update its configuration to use the new seal blocks (completely unaware of the old seal type) and bring it back up."

The following sentence does not read easily:
"Take down the old active node, update its configuration of the old active node to use the new seal blocks (completely unaware of the old seal type) and bring it back up."
I have changed this to the sentence below, which I believe reads better.
Take down the old active node, update its configuration to use the new seal blocks (completely unaware of the old seal type) and bring it back up.
@kwagga kwagga requested a review from taoism4504 as a code owner November 9, 2021 14:05
@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Nov 9, 2021

CLA assistant check
All committers have signed the CLA.

@kwagga kwagga changed the title Update seal.mdx Documentation grammar update for https://www.vaultproject.io/docs/concepts/seal#migration-post-vault-1-5-1 Nov 9, 2021
Copy link
Copy Markdown
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread website/content/docs/concepts/seal.mdx Outdated
Comment thread website/content/docs/concepts/seal.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants