Backport of Documentation grammar update for https://www.vaultproject.io/docs/concepts/seal#migration-post-vault-1-5-1 into release/1.11.x#16867
Merged
tomhjp merged 4 commits intoAug 31, 2022
Conversation
hc-github-team-secure-vault-core
requested a review
from taoism4504
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/kwagga-patch-1/usually-refined-dassie
branch
2 times, most recently
from
e0c31fc to
f205fac
Compare
kwagga
approved these changes
Aug 25, 2022
Contributor
kwagga
left a comment
kwagga
left a comment
There was a problem hiding this comment.
Thank you for catching that. LGTM
Contributor
|
@taoism4504, Would you mind approving this? |
tomhjp
approved these changes
Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #13092 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
The following sentence does not read easily:
"Take down the old active node, update its configuration of the old active node to use the new seal blocks (completely unaware of the old seal type) and bring it back up."
I have changed this to the sentence below, which I believe reads better.
"Take down the old active node, update its configuration to use the new seal blocks (completely unaware of the old seal type) and bring it back up."
Overview of commits