Skip to content

Ensure valid field is returned when set to false#30852

Merged
rculpepper merged 3 commits into
mainfrom
rculpepper/transit-verify-valid
Jun 9, 2025
Merged

Ensure valid field is returned when set to false#30852
rculpepper merged 3 commits into
mainfrom
rculpepper/transit-verify-valid

Conversation

@rculpepper
Copy link
Copy Markdown
Contributor

Description

With omitempty, the valid field won't be returned in batch_results if the provided HMAC is invalid

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@rculpepper rculpepper requested a review from a team as a code owner June 4, 2025 20:28
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 4, 2025
@rculpepper rculpepper requested a review from a team as a code owner June 4, 2025 20:30
@rculpepper rculpepper requested a review from lursu June 4, 2025 20:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2025

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2025

Build Results:
All builds succeeded! ✅

Copy link
Copy Markdown
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rculpepper rculpepper merged commit 8cf4caa into main Jun 9, 2025
92 checks passed
@rculpepper rculpepper deleted the rculpepper/transit-verify-valid branch June 9, 2025 15:40
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
* remove omitempty to ensure valid is always returned

* add changelog

* add test
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
* remove omitempty to ensure valid is always returned

* add changelog

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants