Skip to content

Backport of Ensure valid field is returned when set to false into release/1.19.x#30917

Merged
rculpepper merged 1 commit into
release/1.19.xfrom
backport/rculpepper/transit-verify-valid/lately-literate-urchin
Jun 9, 2025
Merged

Backport of Ensure valid field is returned when set to false into release/1.19.x#30917
rculpepper merged 1 commit into
release/1.19.xfrom
backport/rculpepper/transit-verify-valid/lately-literate-urchin

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #30852 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

The below text is copied from the body of the original PR.


Description

With omitempty, the valid field won't be returned in batch_results if the provided HMAC is invalid

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/rculpepper/transit-verify-valid/lately-literate-urchin branch from 8a21c41 to d6ce400 Compare June 9, 2025 15:41
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 9, 2025
@rculpepper rculpepper enabled auto-merge (squash) June 9, 2025 15:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 9, 2025

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 9, 2025

Build Results:
All builds succeeded! ✅

@rculpepper rculpepper merged commit 607daeb into release/1.19.x Jun 9, 2025
83 of 85 checks passed
@rculpepper rculpepper deleted the backport/rculpepper/transit-verify-valid/lately-literate-urchin branch June 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants