Skip to content

Backport of UI: Revert api service use for requests to sys/internal/ui/mounts into release/1.20.x#31100

Closed
hc-github-team-secure-vault-core wants to merge 1 commit into
release/1.20.xfrom
backport/ui/VAULT-37428/revert-api-service-for-mounts/naturally-current-python
Closed

Backport of UI: Revert api service use for requests to sys/internal/ui/mounts into release/1.20.x#31100
hc-github-team-secure-vault-core wants to merge 1 commit into
release/1.20.xfrom
backport/ui/VAULT-37428/revert-api-service-for-mounts/naturally-current-python

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #31094 to be assessed for backporting due to the inclusion of the label backport/1.20.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@hellobontempo
This person should resolve the merge-conflict(s) by either:

  • Manually completing the cherry picks into this branch
  • Creating a new branch and manually cherry-picking all commits being backported

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

The new api service automatically camelizes the keys of the response params when it returns the server data.
This is fine for parameters that were previously ember data model attributes because we often referenced those as camel cased variables.

However, for items that are actual mount paths (like secret engines or auth methods) this actually changes the value of the path. It doesn't seem to normalize dasherized paths, but if a mount is snake-cased then it camelizes it which changes the original value. This PR reverts the use of the api service for internalUiListEnabledVisibleMounts until we've decided how to handle this in the service itself.

Actual API response

{
    "auth": {
        "oidc_test/": {
            "description": "",
            "options": {},
            "type": "oidc"
        }
    },
    "secret": {}
}

data returned from api service, notice how oidc_test/ is now oidcTest/

{
    "auth": {
        "oidcTest/": {
            "description": "",
            "options": {},
            "type": "oidc"
        }
    },
    "secret": {}
}

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 25, 2025
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@hellobontempo
Copy link
Copy Markdown
Contributor

closed for: #31101

@hellobontempo hellobontempo deleted the backport/ui/VAULT-37428/revert-api-service-for-mounts/naturally-current-python branch June 25, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants