Skip to content

UI: Revert api service use for requests to sys/internal/ui/mounts#31094

Merged
hellobontempo merged 3 commits into
mainfrom
ui/VAULT-37428/revert-api-service-for-mounts
Jun 25, 2025
Merged

UI: Revert api service use for requests to sys/internal/ui/mounts#31094
hellobontempo merged 3 commits into
mainfrom
ui/VAULT-37428/revert-api-service-for-mounts

Conversation

@hellobontempo
Copy link
Copy Markdown
Contributor

@hellobontempo hellobontempo commented Jun 25, 2025

Description

✅ enterprise tests pass

The new api service automatically camelizes the keys of the response params when it returns the server data.
This is fine for parameters that were previously ember data model attributes because we often referenced those as camel cased variables.

However, for items that are actual mount paths (like secret engines or auth methods) this actually changes the value of the path. It doesn't seem to normalize dasherized paths, but if a mount is snake-cased then it camelizes it which changes the original value. This PR reverts the use of the api service for internalUiListEnabledVisibleMounts until we've decided how to handle this in the service itself.

Actual API response

{
    "auth": {
        "oidc_test/": {
            "description": "",
            "options": {},
            "type": "oidc"
        }
    },
    "secret": {}
}

data returned from api service, notice how oidc_test/ is now oidcTest/

{
    "auth": {
        "oidcTest/": {
            "description": "",
            "options": {},
            "type": "oidc"
        }
    },
    "secret": {}
}

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.20.1 milestone Jun 25, 2025
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 25, 2025

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo added backport/1.20.x and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jun 25, 2025
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 25, 2025
@hellobontempo hellobontempo marked this pull request as ready for review June 25, 2025 17:53
@hellobontempo hellobontempo requested review from a team as code owners June 25, 2025 17:53
@hellobontempo hellobontempo requested review from AnPucel and removed request for AnPucel June 25, 2025 17:53
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@hellobontempo hellobontempo merged commit b97bdc4 into main Jun 25, 2025
42 of 54 checks passed
@hellobontempo hellobontempo deleted the ui/VAULT-37428/revert-api-service-for-mounts branch June 25, 2025 18:22
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
…ashicorp#31094)

* revert api service use for sys/internal/ui/mounts

* add changelog

* replace this.api.sys.internalUiListEnabledVisibleMounts with ajax request to sys/internal/ui/mounts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants