UI: Revert api service use for requests to sys/internal/ui/mounts#31094
Merged
hellobontempo merged 3 commits intoJun 25, 2025
Conversation
|
CI Results: |
…uest to sys/internal/ui/mounts
emoncuso
approved these changes
Jun 25, 2025
|
Build Results: |
6 tasks
6 tasks
9 tasks
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
…ashicorp#31094) * revert api service use for sys/internal/ui/mounts * add changelog * replace this.api.sys.internalUiListEnabledVisibleMounts with ajax request to sys/internal/ui/mounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
✅ enterprise tests pass
The new api service automatically camelizes the keys of the response params when it returns the server data.
This is fine for parameters that were previously ember data model attributes because we often referenced those as camel cased variables.
However, for items that are actual mount paths (like secret engines or auth methods) this actually changes the value of the path. It doesn't seem to normalize dasherized paths, but if a mount is snake-cased then it camelizes it which changes the original value. This PR reverts the use of the api service for
internalUiListEnabledVisibleMountsuntil we've decided how to handle this in the service itself.Actual API response
data returned from api service, notice how
oidc_test/is nowoidcTest/TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.