Skip to content

[UI] Ember Data Migration - Reversions#31347

Merged
zofskeez merged 1 commit into
mainfrom
ui/api-migration-reversions
Jul 22, 2025
Merged

[UI] Ember Data Migration - Reversions#31347
zofskeez merged 1 commit into
mainfrom
ui/api-migration-reversions

Conversation

@zofskeez
Copy link
Copy Markdown
Contributor

Description

Prior to the casing updates to the API client, #31094 and #31150 reverted some usages of the api service. This PR adds them back in.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@zofskeez zofskeez added this to the 1.21.0-rc1 milestone Jul 21, 2025
@zofskeez zofskeez added the ui label Jul 21, 2025
@zofskeez zofskeez requested a review from a team as a code owner July 21, 2025 19:06
@github-actions github-actions Bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 21, 2025
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 21, 2025

CI Results:
All Go tests succeeded! ✅

Copy link
Copy Markdown
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zofskeez zofskeez merged commit c710206 into main Jul 22, 2025
50 of 52 checks passed
@zofskeez zofskeez deleted the ui/api-migration-reversions branch July 22, 2025 17:57
@zofskeez zofskeez mentioned this pull request Jul 22, 2025
9 tasks
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants