[UI] Enterprise Test Fixes#31355
Conversation
github-actions
Bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
| test('it falls back error template if no permission', async function (assert) { | ||
| this.server.get('/sys/config/ui/login/default-auth', () => overrideResponse(403)); | ||
| await visit('vault/config-ui/login-settings'); | ||
| assert |
There was a problem hiding this comment.
This test change is actually what prompted me to ask you about consistent error handling a few weeks ago! I remember you saying it was on your radar. The new api service error messages display kind of funky. Is the eventual end goal to have them all show similar info? Maybe we don't need to show the URL but that might be useful
There was a problem hiding this comment.
Yes so my plan is to consistently use the Page::Error component but it's something I want to circle back too since it needs to be updated in many places. The error handling is all over the place. Realistically, unless there is a specific case to display something different we should let the error bubble up to the top level and use the component (which has already been updated) rather than having individual error templates in child routes that are very similar.
There was a problem hiding this comment.
That's right, thank you for reiterating! Yes - it is definitely all over the place. Sounds good - I agree 😄
hellobontempo
left a comment
hellobontempo
left a comment
There was a problem hiding this comment.
Aha! Someone didn't run enterprise tests 😉 Lol, just giving you a hard time!
For what it's worth, I think after some of the stabilizing PRs I merged a few weeks ago, running enterprise tests on main should consistently pass via yarn test:ent
There were lots of problems of 1.20, but I haven't had issues on main so far 🤞
😁 I've given up running them locally because tests are always failing and it's hard to tell if it's from my changes. But in this case I just totally missed these which were clearly in the PR's I was reverting 😞 |
2 participants
Description
Fixes a couple of enterprise tests that were failing from #31347
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.