Sanitize Vault version strings for Kubernetes#8411
Merged
Conversation
kalafut
reviewed
Feb 21, 2020
kalafut
reviewed
Feb 21, 2020
tyrannosaurus-becks
added a commit
that referenced
this pull request
Mar 2, 2020
* sanitize vault version strings for kube * replace disallowed chars with dashes * use strings.Map * use switch for whitelisted chars
tyrannosaurus-becks
added a commit
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have found that if the Vault version contains a "+", as is used with Vault enterprise, the Kubernetes API returns a 422 and service registration fails.
This PR adds a
Sanitizemethod to the hand-rolled Kube client, which is then used by Kube service registration to clean the Vault version string.When creating this PR, I considered the possibility of using
regex. I chose this approach because in my opinion, this is the most readable/maintainable option, however, I am flexible on that as it's quite subjective.