Backport 1.4.x: Sanitize Vault version strings for Kubernetes#8451
Merged
Conversation
* sanitize vault version strings for kube * replace disallowed chars with dashes * use strings.Map * use switch for whitelisted chars
Contributor
|
Could you add a description to this PR please? In particular I'd like to see: basic description of what it's doing, why we're doing it, any PRs/issues that are relevant to this PR. In particular, can this reference back to the PR that originally did the sanitization? Thanks! |
Contributor
Author
|
@pcman312 ah yes, I should have linked the PR. Added! It has all the details. |
pcman312
approved these changes
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #8411, please see there for further detail. This PR is intended to be included in the 1.4 GA.