cmake: Fix and improve hardening for Windows#74
Merged
Conversation
Owner
Author
|
Friendly ping @fanquake @theuni @TheCharlatan :) |
hebasto
force-pushed
the
240109-cmake-AW
branch
from
586affa to
789f402
Compare
Owner
Author
|
Rebased. |
hebasto
force-pushed
the
cmake-staging
branch
from
67ceebb to
203a3ab
Compare
hebasto
force-pushed
the
240109-cmake-AW
branch
from
789f402 to
509e766
Compare
Owner
Author
|
Rebased. |
theuni
reviewed
Jan 19, 2024
theuni
left a comment
theuni
left a comment
There was a problem hiding this comment.
ACK after addressing documentation comment.
| endif() | ||
|
|
||
| if(NOT HARDENING AND "@no_harden@" STREQUAL "1") | ||
| set(HARDENING OFF CACHE STRING "") |
There was a problem hiding this comment.
I was expecting to see this set hardening to true if not @no_harden@, but it's already the default in the main build. So it's doing the same thing as our config.site which makes sense.
hebasto
force-pushed
the
240109-cmake-AW
branch
from
509e766 to
78ff251
Compare
fanquake
reviewed
Jan 23, 2024
Owner
Author
|
As it was mentioned during yesterday's meeting, if it won't hurt or have any significant drawbacks why not providing Or, even better, |
hebasto
force-pushed
the
240109-cmake-AW
branch
from
78ff251 to
cad5f28
Compare
hebasto
force-pushed
the
cmake-staging
branch
from
ff2f574 to
dacc6f7
Compare
hebasto
force-pushed
the
240109-cmake-AW
branch
from
cad5f28 to
f89271c
Compare
Owner
Author
|
Rebased. |
hebasto
force-pushed
the
240109-cmake-AW
branch
from
f89271c to
c54f9e1
Compare
hebasto
force-pushed
the
240109-cmake-AW
branch
from
c54f9e1 to
06fc8c6
Compare
Owner
Author
|
This PR and its description have been updated per feedback from the recent call on 2024-02-01. |
Make added flags language-wide, which means they will be passed to all invocations of the compiler including both compiling and linking.
hebasto
force-pushed
the
240109-cmake-AW
branch
from
06fc8c6 to
d889870
Compare
|
LGTM |
sedited
approved these changes
Feb 9, 2024
Merged
hebasto
added a commit
that referenced
this pull request
Feb 9, 2024
0d985e5 fixup! cmake: Add `TryAppendCXXFlags` module (Hennadii Stepanov) Pull request description: This PR is a follow-up on #74. No need to try a flag in the linker context if it is not supported in the compiler context. For example, on the staging branch: ``` $ env CC=clang CXX=clang++ cmake -B build ... -- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE -- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE - Failed CMake Warning at cmake/module/TryAppendCXXFlags.cmake:125 (message): The -fstack-reuse=none fail(s) to link. Call Stack (most recent call first): CMakeLists.txt:310 (try_append_cxx_flags) ... ``` Top commit has no ACKs. Tree-SHA512: 6e73f00838eeb066635cbbf1acb41955b32a83e9939b1cabe62152b312d2e9c1f8dcacb6b11f529769b541925cc778d9e63e0968615ff4404a393115199300f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some compile flags, for example
-fstack-protector-all, might impact the linking stage as well. Instead of guessing, this PR makes thetry_append_cxx_flagsfunction add new flags in both compile and link contexts.