Skip to content

cmake: Follow-up on PR74#98

Merged
hebasto merged 1 commit into
cmake-stagingfrom
240209-cmake-BN
Feb 9, 2024
Merged

cmake: Follow-up on PR74#98
hebasto merged 1 commit into
cmake-stagingfrom
240209-cmake-BN

Conversation

@hebasto
Copy link
Copy Markdown
Owner

@hebasto hebasto commented Feb 9, 2024

This PR is a follow-up on #74.

No need to try a flag in the linker context if it is not supported in the compiler context.

For example, on the staging branch:

$ env CC=clang CXX=clang++ cmake -B build
...
-- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE
-- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE - Failed
CMake Warning at cmake/module/TryAppendCXXFlags.cmake:125 (message):
  The -fstack-reuse=none fail(s) to link.
Call Stack (most recent call first):
  CMakeLists.txt:310 (try_append_cxx_flags)


...

No need to try a flag in the linker context if it is not supported in
the compiler context.
@hebasto
Copy link
Copy Markdown
Owner Author

hebasto commented Feb 9, 2024

@hebasto hebasto merged commit 9b72eb1 into cmake-staging Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants