Skip to content

Fix grammatical error in merge_consecutive_op validation message#1124

Merged
VisLab merged 2 commits intomainfrom
copilot/fix-d4d918b3-c164-453f-97c6-e76f56e4b8de
Sep 30, 2025
Merged

Fix grammatical error in merge_consecutive_op validation message#1124
VisLab merged 2 commits intomainfrom
copilot/fix-d4d918b3-c164-453f-97c6-e76f56e4b8de

Conversation

Copy link
Contributor

Copilot AI commented Sep 30, 2025

Description

This PR fixes a grammatical error (double negative) in the error message returned by MergeConsecutiveOp.validate_input_data().

Changes

The error message previously read:

f"column_name `{name}` cannot not be a match_column."

This has been corrected to:

f"column_name `{name}` cannot be a match_column."

The double negative "cannot not" has been changed to the clearer "cannot", making the error message more professional and easier to understand.

Impact

Testing

  • ✅ All 8 tests in test_merge_consecutive_op.py pass
  • ✅ All 6 tests in test_validator.py pass
  • ✅ All 91 tests in the remodeling operations directory pass
  • ✅ Verified no other instances of this typo exist in the codebase
Original prompt

The agent did not complete the request in PR #1123 before it was merged. Please continue


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: VisLab <1189050+VisLab@users.noreply.github.com>
Copilot AI changed the title [WIP] The agent did not complete the request in PR #1123 before it was merged. Please continue Fix grammatical error in merge_consecutive_op validation message Sep 30, 2025
Copilot AI requested a review from VisLab September 30, 2025 16:28
@VisLab VisLab marked this pull request as ready for review September 30, 2025 17:57
@VisLab VisLab merged commit 6c993d6 into main Sep 30, 2025
28 checks passed
@VisLab VisLab deleted the copilot/fix-d4d918b3-c164-453f-97c6-e76f56e4b8de branch October 3, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants