Skip to content

Fix grammatical error in merge_consecutive_op validation message #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 2 commits into from
Sep 30, 2025
Merged

Fix grammatical error in merge_consecutive_op validation message #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f688a66
Initial plan
Copilot Sep 30, 2025
c08cd29
Fix double negative typo: 'cannot not be' → 'cannot be'
Copilot Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hed/tools/remodeling/operations/merge_consecutive_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,5 +188,5 @@ def validate_input_data(parameters):
match_columns = parameters.get("match_columns", None)
name = parameters.get("column_name", None)
if match_columns and name in match_columns:
return [f"column_name `{name}` cannot not be a match_column."]
return [f"column_name `{name}` cannot be a match_column."]
return []
2 changes: 1 addition & 1 deletion tests/tools/remodeling/test_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def test_validate_parameter_data(self):
merge_consecutive_validate[0]["parameters"]["match_columns"].append("trial_type")
error_strings = self.validator.validate(merge_consecutive_validate)
self.assertEqual(error_strings[0], "Operation 1 (merge_consecutive): column_name `trial_type` " +
"cannot not be a match_column.")
"cannot be a match_column.")

remap_columns_validate_same_length = [deepcopy(self.remodel_file)[5]]
remap_columns_validate_same_length[0]["parameters"]["map_list"][0] = [""]
Expand Down
Loading