Skip to content

Subnets updates trichards#224

Closed
trichards-hiro wants to merge 3 commits intohirosystems:masterfrom
trichards-hiro:subnets-updates-trichards
Closed

Subnets updates trichards#224
trichards-hiro wants to merge 3 commits intohirosystems:masterfrom
trichards-hiro:subnets-updates-trichards

Conversation

@trichards-hiro
Copy link
Copy Markdown
Contributor

Description

Subnets need technical documentation for developers to understand how to use subnets. This PR includes new subnets technical content and documentation.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #224 (80c0629) into master (e23b941) will increase coverage by 92.26%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master     #224       +/-   ##
===========================================
+ Coverage        0   92.26%   +92.26%     
===========================================
  Files           0        6        +6     
  Lines           0      336      +336     
===========================================
+ Hits            0      310      +310     
- Misses          0       26       +26     
Impacted Files Coverage Δ
core-contracts/contracts/helper/test-helpers.clar 100.00% <0.00%> (ø)
...contracts/contracts/helper/simple-nft-no-mint.clar 66.66% <0.00%> (ø)
core-contracts/contracts/helper/simple-nft.clar 73.33% <0.00%> (ø)
core-contracts/contracts/subnet.clar 94.96% <0.00%> (ø)
core-contracts/contracts/helper/simple-ft.clar 75.00% <0.00%> (ø)
core-contracts/contracts/multi-miner.clar 97.05% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trichards-hiro. This structure looks great. There are a bunch of updates needed in the processes. I'll open a PR against this one with updates.


# Getting Started

Subnets can be built using any of the following methods:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs many updates. I'll send a revision today.

In order to call the deposit NFT function in the hyperchains interface contract, the principal `USER_ADDR` must be called using the command shown below.

```
node ./deposit_nft.js 3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be more helpful to users if we more directly show them the contract calls that need to be made, and show the calls to stacks.js, instead of using these scripts here. I will update.

Lock file: /var/lock/subsys/stacks (SysVinit)

The PID directory and data directory should both be owned by the
The PID directory and data directory should be owned by both the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "both" here is better in the original location, referring to both directories.

@obycode
Copy link
Copy Markdown
Contributor

obycode commented Mar 6, 2023

Since I wasn't able to push to this branch on your fork, I pushed a new branch with updates to the devnet walkthrough, docs-updates. I will add one more section to getting-started.md for interacting with the testnet subnet once we have deployed it.

@obycode
Copy link
Copy Markdown
Contributor

obycode commented Mar 15, 2023

This was merged into #225

@obycode obycode closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants