Conversation
kantai
left a comment
kantai
left a comment
There was a problem hiding this comment.
I had a bunch of point-suggestions, and a few higher level comments (the biggest is regarding the how-to-guides)
|
Thanks for all of those edits @kantai. I've integrated those and pushed an update. The remaining work is to add the testnet part, but I'm thinking we should go ahead and get this published, then add the testnet info in a separate PR once the testnet environment is actually up and running. @trichards-hiro, there are a couple of remaining comments from @kantai for discussion. |
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 91.19% 92.26% +1.06%
==========================================
Files 6 6
Lines 284 336 +52
==========================================
+ Hits 259 310 +51
- Misses 25 26 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Reminder: Should we delete NFT_USE_CASE.md in this PR? |
This is replaced with the tutorial in getting-started.md.
This content is specific to the tutorial and needs to be re-worked to make sense for a more generate how-to guide. How-tos will be added in a future update.
This content is not relevant at the moment.
|
I deleted the how-tos and cleaned up some other files so that we can get the updated tutorial walkthrough released. |
|
@kantai or @LakshmiLavanyaKasturi can I get an approval on this. The latest commit removes the how-tos for now, so that we can get the updated tutorial merged to avoid confusion. |
|
LGTM. Thanks Brice. |
5 participants
Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml