ci: Push to DockerHub on branch commits, but only if we have credentials#258
Merged
jbencin merged 1 commit intohirosystems:masterfrom Apr 18, 2023
Merged
Conversation
jbencin
force-pushed
the
ci/publish-branches-to-dockerhub
branch
from
2a77c85 to
06126f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 6 6
Lines 337 337
=======================================
Hits 315 315
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
obycode
approved these changes
Apr 18, 2023
Contributor
obycode
left a comment
obycode
left a comment
There was a problem hiding this comment.
Seems like that should work. Thanks for looking into this 👍
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Push to DockerHub on branch commits, but only if we have credentials. This will make it easier to develop using
clarinet integrate, which by default pulls Subnets from DockerHubAdditional info (benefits, drawbacks, caveats)
This PR reverts a change I made in #214, but only attempts the push to DockerHub if we have credentials, so we won't get CI failures when working in forked repos