ci: Add explicit != '' comparisons to test if strings are non-empty#262
Merged
jbencin merged 1 commit intohirosystems:masterfrom Apr 20, 2023
Merged
Conversation
obycode
approved these changes
Apr 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 6 6
Lines 338 338
=======================================
Hits 316 316
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
docker pushstep of CI by explicitly checking if a string is empty using!=, rather than relying on an implicit castAdditional info (benefits, drawbacks, caveats)
This fixes an issue introduced by #258. If you check here, when I made these changes they worked fine. I'm not sure what changed since them to make it fail now.
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml