Skip to content

ci: Add explicit != '' comparisons to test if strings are non-empty#262

Merged
jbencin merged 1 commit intohirosystems:masterfrom
jbencin:ci/fix-implicit-bool-cast
Apr 20, 2023
Merged

ci: Add explicit != '' comparisons to test if strings are non-empty#262
jbencin merged 1 commit intohirosystems:masterfrom
jbencin:ci/fix-implicit-bool-cast

Conversation

@jbencin
Copy link
Copy Markdown
Contributor

@jbencin jbencin commented Apr 20, 2023

Description

Fixes the docker push step of CI by explicitly checking if a string is empty using !=, rather than relying on an implicit cast

Additional info (benefits, drawbacks, caveats)

This fixes an issue introduced by #258. If you check here, when I made these changes they worked fine. I'm not sure what changed since them to make it fail now.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin requested a review from obycode April 20, 2023 13:27
Copy link
Copy Markdown
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jbencin!

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2023

Codecov Report

Merging #262 (1729198) into master (3a0ef04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           6        6           
  Lines         338      338           
=======================================
  Hits          316      316           
  Misses         22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jbencin jbencin merged commit 82d44f0 into hirosystems:master Apr 20, 2023
@jbencin jbencin deleted the ci/fix-implicit-bool-cast branch May 26, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants