fix: Should fix failures reading subnet contract version#277
Merged
obycode merged 1 commit intohirosystems:masterfrom Jun 8, 2023
Merged
fix: Should fix failures reading subnet contract version#277obycode merged 1 commit intohirosystems:masterfrom
obycode merged 1 commit intohirosystems:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Properly deserialize response from call to read-only function
get-versioninsubnet.clarApplicable issues
Additional info (benefits, drawbacks, caveats)
This is somewhat messy, and contains some
unwrap()s andpanic!()s when things don't go as expected (although I don't really expect them to ever be triggered). We are trying to get this out ASAP, so I'll clean up later.Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml