Skip to content

fix: Should fix failures reading subnet contract version#277

Merged
obycode merged 1 commit intohirosystems:masterfrom
jbencin:fix/subnet-contract-versioning
Jun 8, 2023
Merged

fix: Should fix failures reading subnet contract version#277
obycode merged 1 commit intohirosystems:masterfrom
jbencin:fix/subnet-contract-versioning

Conversation

@jbencin
Copy link
Copy Markdown
Contributor

@jbencin jbencin commented Jun 7, 2023

Description

Properly deserialize response from call to read-only function get-version in subnet.clar

Applicable issues

Additional info (benefits, drawbacks, caveats)

This is somewhat messy, and contains some unwrap()s and panic!()s when things don't go as expected (although I don't really expect them to ever be triggered). We are trying to get this out ASAP, so I'll clean up later.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin requested a review from obycode June 7, 2023 22:43
Copy link
Copy Markdown
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obycode obycode merged commit 36b6b35 into hirosystems:master Jun 8, 2023
@jbencin jbencin deleted the fix/subnet-contract-versioning branch June 15, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subnet contract version check doesn't work right

2 participants