Skip to content

[BUG]: Coati train_rm use naive stra #3366

@cauyxy

Description

@cauyxy

🐛 Describe the bug

image
Description:
When attempting to save a model using the save_model() method in the coati/trainer/rm.py module, an error is encountered with an unexpected keyword argument 'tokenizer'. The error traceback suggests that the error occurs in line 135 of the coati/trainer/rm.py file.

Steps to Reproduce:

Run the train_rm.sh script.
Call the save_model() method with the 'tokenizer' keyword argument.
Expected Behavior:
The save_model() method should save the model without any errors or issues.

Actual Behavior:
The save_model() method raises a TypeError with the message "save_model() got an unexpected keyword argument 'tokenizer'".

Possible Solution:
It seems that the save_model() method in the coati/trainer/rm.py module does not expect a 'tokenizer' keyword argument. To resolve the issue, either remove the 'tokenizer' argument when calling the save_model() method, or modify the method to accept the 'tokenizer' argument if it is required for the intended functionality.

Additional Information:

Version of Coati used: 1.0.0
Python version: 3.7
Operating system: Linux

Environment

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions