Skip to content

[chat] fix save_model in naive and ddp strategy#3436

Merged
Fazziekey merged 1 commit intohpcaitech:mainfrom
chengeharrison:fix/chat
Apr 4, 2023
Merged

[chat] fix save_model in naive and ddp strategy#3436
Fazziekey merged 1 commit intohpcaitech:mainfrom
chengeharrison:fix/chat

Conversation

@chengeharrison
Copy link
Copy Markdown
Contributor

@chengeharrison chengeharrison commented Apr 4, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed #3357, fixed #3366

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Fix save_model in naive and ddp strategy

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@chengeharrison chengeharrison changed the title [chat] fix save_model inin naive and ddp strategy [chat] fix save_model in naive and ddp strategy Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Coati train_rm use naive stra [BUG]: TypeError: save_model() got an unexpected keyword argument 'tokenizer'

2 participants