[fx] provide an accurate estimation of memory.#1587
Merged
FrankLeeeee merged 18 commits intohpcaitech:mainfrom Sep 14, 2022
Merged
[fx] provide an accurate estimation of memory.#1587FrankLeeeee merged 18 commits intohpcaitech:mainfrom
FrankLeeeee merged 18 commits intohpcaitech:mainfrom
Conversation
…o feature/better_flop_tensor
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
Contributor
|
Good work. There are some overall comments below:
|
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
reviewed
Sep 13, 2022
FrankLeeeee
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
After hacking the autograd graph and the save_tensors_hook, I managed to compute the accurate memory estimation of
torchvision.models. We can compare the result with #1547.Test