Skip to content

[workflow] fixed broken release workflows#2604

Merged
FrankLeeeee merged 1 commit intomainfrom
hotfix/release-workflow
Feb 6, 2023
Merged

[workflow] fixed broken release workflows#2604
FrankLeeeee merged 1 commit intomainfrom
hotfix/release-workflow

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #2603 .

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the three release workflows. The root cause for each workflow error is:

  1. draft release post: the github api response can have value None for the field author
  2. release to pypi: the needs field has the wrong job name
  3. release to docker: the job status has the wrong github actions context variable

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee added bug Something isn't working DevOps labels Feb 6, 2023
@FrankLeeeee FrankLeeeee merged commit f566b0c into main Feb 6, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/release-workflow branch February 6, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DevOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: the release workflows don't work properly

1 participant