Skip to content

[coati] Fix LlamaCritic#3475

Merged
binmakeswell merged 2 commits intohpcaitech:mainfrom
gongel:main
Apr 7, 2023
Merged

[coati] Fix LlamaCritic#3475
binmakeswell merged 2 commits intohpcaitech:mainfrom
gongel:main

Conversation

@gongel
Copy link
Copy Markdown
Contributor

@gongel gongel commented Apr 6, 2023

🚨 Issue number

fixed #3428

📝 What does this PR do?

mv LlamaForCausalLM to LlamaModel

@JThh JThh mentioned this pull request Apr 6, 2023
10 tasks
@JThh
Copy link
Copy Markdown
Contributor

JThh commented Apr 6, 2023

LGTM.

@binmakeswell binmakeswell changed the title Fix LlamaCritic [coati] Fix LlamaCritic Apr 7, 2023
@binmakeswell binmakeswell requested review from TongLi3701 and ht-zhou and removed request for ht-zhou April 7, 2023 02:38
@TongLi3701
Copy link
Copy Markdown
Contributor

Thanks for your contribution, @gongel !

Could you also remove unused imports such as AutoModelForCausalLM ?

Then I will approve, thanks!

@gongel
Copy link
Copy Markdown
Contributor Author

gongel commented Apr 7, 2023

Thanks for your contribution, @gongel !

Could you also remove unused imports such as AutoModelForCausalLM ?

Then I will approve, thanks!

DONE

Copy link
Copy Markdown
Contributor

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maybe LlamaModel?

4 participants