Skip to content

[coati] Fix LlamaCritic #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binmakeswell merged 2 commits into from
Apr 7, 2023
Merged

[coati] Fix LlamaCritic #3475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
193014d
mv LlamaForCausalLM to LlamaModel
gongel Apr 6, 2023
9478b6c
rm unused imports
gongel Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions applications/Chat/coati/models/llama/llama_critic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
from typing import Optional

import torch
import torch.nn as nn
from transformers import AutoModelForCausalLM, LlamaConfig, LlamaForCausalLM
from transformers import LlamaConfig, LlamaModel

from ..base import Critic

Expand All @@ -28,11 +27,11 @@ def __init__(self,
**kwargs) -> None:

if pretrained is not None:
model = LlamaForCausalLM.from_pretrained(pretrained)
model = LlamaModel.from_pretrained(pretrained)
elif config is not None:
model = LlamaForCausalLM(config)
model = LlamaModel(config)
else:
model = LlamaForCausalLM(LlamaConfig())
model = LlamaModel(LlamaConfig())

if checkpoint:
model.gradient_checkpointing_enable()
Expand Down