Skip to content

[workflow] fixed the docker build workflow#3794

Merged
ver217 merged 2 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/docker-ci
May 22, 2023
Merged

[workflow] fixed the docker build workflow#3794
ver217 merged 2 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/docker-ci

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3793

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR refactored the workflow for docker release. The changes include:

  1. fix the yaml file format
  2. only trigger this workflow when a release is published.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217 ver217 merged commit 788e07d into hpcaitech:main May 22, 2023
FrankLeeeee added a commit that referenced this pull request May 24, 2023
* [workflow] fixed the docker build workflow

* polish code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: only release docker when a tag is created

2 participants