Skip to content

[workflow] fixed the docker build workflow #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ver217 merged 2 commits into from
May 22, 2023
Merged

[workflow] fixed the docker build workflow #3794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74ed640
[workflow] fixed the docker build workflow
FrankLeeeee May 22, 2023
dfffe8e
polish code
FrankLeeeee May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .../workflows/release_docker_after_merge.yml → ...orkflows/release_docker_after_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
name: Publish Docker Image to DockerHub after Merge
name: Publish Docker Image to DockerHub after Publish

on:
workflow_dispatch:
pull_request:
paths:
- 'version.txt'
types:
- closed
release:
types: [published]

jobs:
release:
Expand All @@ -26,7 +23,7 @@ jobs:
run: |
version=$(cat version.txt)
tag=hpcaitech/colossalai:$version
docker build --build-arg http_proxy=http://172.17.0.1:7890 --build-arg https_proxy=http://172.17.0.1:7890 --build-arg VERSION=v${version} -t $tag ./docker
docker build --build-arg http_proxy=http://172.17.0.1:7890 --build-arg https_proxy=http://172.17.0.1:7890 --build-arg VERSION=v${version} -t $tag ./docker
echo "tag=${tag}" >> $GITHUB_OUTPUT

- name: Log in to Docker Hub
Expand All @@ -50,7 +47,7 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: '3.8.14'
python-version: "3.8.14"

- name: Install requests
run: pip install requests
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/report_test_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
report-test-coverage:
runs-on: ubuntu-latest
steps:
- name: 'Download artifact'
- name: "Download artifact"
uses: actions/github-script@v6
with:
script: |
Expand All @@ -31,7 +31,7 @@ jobs:
let fs = require('fs');
fs.writeFileSync(`${process.env.GITHUB_WORKSPACE}/report.zip`, Buffer.from(download.data));

- name: 'Unzip artifact'
- name: "Unzip artifact"
id: unzip
run: |
unzip report.zip
Expand All @@ -58,7 +58,7 @@ jobs:
echo "</details>" >> coverage_report.txt
mv coverage_report.txt coverage.txt

- name: 'Comment on PR'
- name: "Comment on PR"
if: steps.unzip.outputs.hasReport == 'true'
uses: actions/github-script@v6
with:
Expand Down