Skip to content

[requirements/] Add pytest and decorator to requirements.txt#3963

Closed
MEllis-github wants to merge 2 commits intohpcaitech:mainfrom
MEllis-github:main
Closed

[requirements/] Add pytest and decorator to requirements.txt#3963
MEllis-github wants to merge 2 commits intohpcaitech:mainfrom
MEllis-github:main

Conversation

@MEllis-github
Copy link
Copy Markdown

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • [] I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

fixed #3962

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

Add pytest and decorator to requirements.txt

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

[requirements/] Add pytest and decorator to requirements.txt
@FrankLeeeee
Copy link
Copy Markdown
Contributor

hi, let me try to reproduce this bug, ideally we should have pytest for this library, pytest is only needed when running testing.

@FrankLeeeee
Copy link
Copy Markdown
Contributor

Hi @MEllis-github , I think decorator will be installed as a dependency of fabric. May I know which version of fabric you have installed?

Screenshot 2023-06-12 at 11 28 41

As for the pytest error report, you can just move this line in the colossalai.testing.pytest_wrapper.py.

import os
- import pytest

def run_on_environment_flag(name: str):
    ...

+   import pytest
    assert isinstance(name, str)

@MEllis-github
Copy link
Copy Markdown
Author

I will check.
In the meantime, to be clear, this was triggered by running colossalai -i check in/using docker.io/hpcaitech/colossalai:0.3.0.
The only additional dependencies installed were the following for autoparallel

RUN pip install --no-cache-dir "transformers>=4.23.1" "pulp>=2.7.0" && \
    conda install -y -c conda-forge coin-or-cbc && \
...

@FrankLeeeee
Copy link
Copy Markdown
Contributor

Fixed by #4087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: pytest and decorator required but missing in v0.3.0 requirements

2 participants